search

ligos / readablepassphrasegenerator

The Readable Passphrase Generator generates passphrases which are (mostly) grammatically correct but nonsensical. These are easy to remember (for humans) but difficult to guess (for humans and computers).
Apache License 2.0
150 stars 10 forks source link

Failed to generate a password / Custom Dictionnary #21

Open regisdenice opened 2 weeks ago

regisdenice commented 2 weeks ago

Thank you for making this plugin, I think your plugin has a great potential :tada: :partying_face:

Goal

Enjoy your plugin in my language [^1]

[^1]:I understand better my language than English than C# :D I have more trouble remembering the unknown words that might form a sentence that makes no sense but is grammatically almost correct.

Action

I am building a French dictionary, and I share my 0.1 test version ReadablePassphrase - French 0_1.xml [^2] [^2]: As I did not find a template, my dictionary is based on: your example: https://github.com/ligos/readablepassphrasegenerator/wiki/Make-Your-Own-Dictionary and your dictionaries: https://github.com/ligos/readablepassphrasegenerator/tree/master/trunk/MergePartsOfSpeech

Issue

The Preview tab Failed to generate a password, withe either message:

  1. The sequence contains no matching elements [^3]
  2. maxExlusive must be positive Parameter Name: maxExlusive The actual value was 0. [^4]

Note; your plugin creates password with my own dictionary :smile: :+1: _

[^3]: The sequence contains no matching elements 2024 08 23 - 18 55 47 Preview Exception Often 2024 08 23 - 18 55 03 Configuration [^4]: maxExlusive must be positive Parameter Name: maxExlusive The actual value was 0. 2024 08 23 - 18 55 53 Preview Exception Rarely 2024 08 23 - 19 24 39 Configuration Reopened

How to reproduce ?

  1. KeePass > Tools > Generate Password... > Generating using custom algorithm > Readable Passphrase Generator > Options > Use your own dictionary > ReadablePassphrase - French 0_1.xml > OK > Preview tab [^3]
  2. (Then from the Generating using custom algorithm window) > Options > OK > Preview tab [^4]

Request

In order to build (and share) my dictionary, please could you help me understand what I am missing ?

regisdenice commented 2 weeks ago

I forgot to mention that I do not have this issue when using the built-in dictionary.

ligos commented 2 weeks ago

Hi @regisdenice, looks like you've made a great start to a French dictionary! I wish you well with your work 🙂

I was able to reproduce your error. It looks like its related to numbers. It appears the plugin assumes a dictionary has at least one number.

I was able to resolve the issue by adding a <numberRange> to your dictionary: image

The only way to add numbers is via <numberRange>. That is OK for numerals (like 1, 2, 3, etc). But I'll make another issue to add <number value="one"> or <number value="un">, at some time in the future.

Let me know if this doesn't work. Murray

ligos commented 2 weeks ago

https://github.com/ligos/readablepassphrasegenerator/issues/22