liguista / sk-dvx

Automatically exported from code.google.com/p/sk-dvx
0 stars 0 forks source link

Improve handling of a user who has been marked as 'inactive' in DVX (corrected) #114

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Before the DescribeAthon14, two users tried to create descriptions but received 
long, Java error messages in the addCreate page.

Keith did some investigation, and reported:

"The two  accounts with problems [...] are inactive, but could log in anyway. 
Once logged in, any attempt to add a movie fails, because the search for a 
user's id only searches active users, therefore the id is null."

We need to consider what marking a user as "inactive" means, and how to handle 
the case where they try to log in to YouDescribe even though they are marked as 
inactive. Possible solutions are:

1/. Immediately mark them as 'active'
2/. Warn them that their account has been marked as inactive, and that they 
will receive an email with a link to re-activate their account (similar to when 
they first sign up for YouDescribe)

Other solutions may be possible.

YouDescribe will need some changes to support either of these solutions. Also, 
YouDescribe should detect the situation where a user's ID is null internally, 
and report the error in a cleaner way then displaying a long Java error.

Original issue reported on code.google.com by Owen.R.E...@gmail.com on 20 May 2014 at 6:00

GoogleCodeExporter commented 8 years ago
Just to clarify, based on discussion with Josh:

A user is created when they sign up, but marked as 'inactive' until they click 
on a link in an email they receive which confirms their email is valid. At this 
point, they can log in without having first clicked the link in the email, but 
they get errors in addCreate.

So, solution #2 is basically what we want to do; flag that they didn't click 
the link in the email, and ask if they want to have the email re-sent.

Original comment by Owen.R.E...@gmail.com on 20 May 2014 at 7:44