lihaibh / ditto

NPM library that helps managing MongoDB snapshots easily and efficiently
https://www.npmjs.com/package/mongodb-snapshot
MIT License
48 stars 6 forks source link

chore: deleted timeout:false option #23

Closed naizapp closed 2 years ago

naizapp commented 3 years ago

No data were been supplied to the pipe other than the metadata. This was happening only for Atlas. The issue happens because setting timeout to false is not supported by Atlas. So deleting that option from cursor solved the issue.

lihaibh commented 3 years ago

@naizapp are you sure it solves size mismatch problem in Atlas? it seems like the default value is 'false' anyway and i think it should not timeout because it might take a while to walk through all documents of a collection when creating a backup. http://mongodb.github.io/node-mongodb-native/3.1/api/Collection.html#find

lihaibh commented 3 years ago

@naizapp thanks for your collaboration but does this change fix anything?

naizapp commented 3 years ago

I've been using this library with this change applied for past 10 days and working for me very well. Before finding out this issue, it was very hard for me for my project because we need to take backups 2 times daily.

PedroKlein commented 2 years ago

@naizapp thanks for your collaboration but does this change fix anything?

I use MongoDB Atlas free tier (M0) and also needed to remove the timeout: false option for it to work, since in the free tier you can't use noTimeout cursors. I've been using it without any problems so far.

lihaibh commented 2 years ago

fixed by: #28