search

lihaoyi / hands-on-scala-js

Better documentation for Scala.js
142 stars 52 forks source link

broken-symlink-fix #12

Closed l15k4 closed 9 years ago

l15k4 commented 9 years ago

Hi,

I'm not sure whether the symlink behavior differs between OS X and Linux, but you need to be in the target directory to create a relative symlink to a directory on Linux ... In case it is not the same on Mac, ignore this PR.

lihaoyi commented 9 years ago

The existing code snippet seems to work on my Ubuntu VM

vagrant@dbdev:~$ mkdir -p js/shared
vagrant@dbdev:~$ mkdir jvm
vagrant@dbdev:~$ ln -s ../js/shared jvm/shared
vagrant@dbdev:~$ touch js/shared/lol
vagrant@dbdev:~$ ls jvm/shared/lol
l15k4 commented 9 years ago

Wow, embarrassing ... Anyway this way is pretty strange in that the relative paths do not correspond to the current $PWD ... I'm kinda used for all that years that relative symlink should be done from the target because it just makes sense only that way if you look at it...

Sorry for useless PR.

lihaoyi commented 9 years ago

The symlink syntax is all wrong in every way. Generally takes me 30-40 minutes to make each one =P