search

lihaoyi / hands-on-scala-js

Better documentation for Scala.js
142 stars 52 forks source link

The weather example needs to be updated: OpenWeatherMap needs registration now =( #30

Open jasonzoladz opened 8 years ago

jasonzoladz commented 8 years ago

Hands-on-Scala-js is fantastic. Thanks so much for putting it together.

You might want to switch the openweathermap api to something else, since:

"Q: API calls return an error 401 A: Starting from 9 October 2015 our API requires a valid APPID for access. Note that this does not mean that our API is subscription-only now - please take a minute to register a free account to receive a key."

http://openweathermap.org/faq#error401

lihaoyi commented 8 years ago

Booo for subscription only =/ I guess I'll need to get a key for find someone else to grab an API from!

fancellu commented 8 years ago

http://www.openweathermap.org/appid#get Its pretty easy to get a key. I had to do exactly the same. https://github.com/fancellu/scalajs-ractive/commit/4847919a3de5c0944649350650d41c4307f06504

adamvoss commented 7 years ago

@lihaoyi I have made the needed changes to the code and documentation. Would you register for a AppId for Hands-on Scala.js using the link @fancellu gave? It seems better if you register it there than I in-case any follow up is needed in the future.