search

lihaoyi / hands-on-scala-js

Better documentation for Scala.js
142 stars 52 forks source link

Big revision of the whole book for Scala.js 1.1.0. #61

Open sjrd opened 4 years ago

sjrd commented 4 years ago

The book had stayed stuck in around 2016, using very old versions of Scala, Scala.js, and libraries. This commit is a full revision of the book to use all the latest versions, along with the right explanations everywhere.

One imporant note is that the workbench-example-app in Getting Started hasn't been updated upstream, but the new text already assumes that it has. So this commit should not be merged yet.

This is blocked on Autowire and then Workbench being published for 1.x. The clientserver2 example is also blocked by Autowire. Autowire has now been published, so this is good.

This is blocked by Workbench being published for 1.x (pending PR at https://github.com/lihaoyi/workbench/pull/53), so that we can update the workbench-example-app.

/cc @gzm0, whom I can't select in the Reviewers list for the PR.

sjrd commented 4 years ago

Updated after the publication of Autowire. Now the only missing piece is Workbench. Alternatively, I could change the Getting Started not to rely on Workbench. It's an essential piece of the story.

gzm0 commented 4 years ago

LGTM up to the last commit. Consider merging just that.

sjrd commented 4 years ago

Thanks :)

Consider merging just that.

Unfortunately that would put master in a slightly inconsistent state, since the text refers to the examples by embedding snippets loaded from the examples in most places, but also has inline code snippets. So although every commit passes the CI on its own, having any of the commits be published on its own would result in the text not being internally consistent.