search

lihaoyi / macropy

Macros in Python: quasiquotes, case classes, LINQ and more!
3.28k stars 178 forks source link

fix for version number not being available when installting from PYPI #37

Closed AvdN closed 11 years ago

AvdN commented 11 years ago

moved version number to macropy/version.py as tuple, which can be easily updated programmaticaly. macropy/init.py exports the tuple as pep 396 compatible string version which is used by setup.py as well

lihaoyi commented 11 years ago

Could we do without version.py and the tuple stuff and just leave the version as a string in __init__.py? I've looked at a bunch of other projects (Flask, SQLAlchemy, etc.) and it doesn't seem most need the easily-programmatically-updated-version-as-tuple. Loathe to have another top level file lying around unless I really need it.

AvdN commented 11 years ago

You don't realy need it, I looked at mutagen and they update the init.py file through rewriting(they use distribute within setup.py). I also have seen seperate version.py files, which you could just overwrite as there is nothing else of value in there.

There is no other reason not to not have _version = (0, 1, 7) directly in init.py, but I do recommend using it as a tuple, in case you ever have to test of major and minor version numbers yourself.

version should be string. but that is more difficult to test against.

I will make a new pull request if you want

On 2013-05-29 17:30, Li Haoyi wrote:

Could we do without |version.py| and the tuple stuff and just leave the version as a string in |init.py|? I've looked at a bunch of other projects (Flask, SQLAlchemy, etc.) and it doesn't seem most need the easily-programmatically-updated-version-as-tuple. Loathe to have another top level file lying around unless I really need it.

— Reply to this email directly or view it on GitHub https://github.com/lihaoyi/macropy/pull/37#issuecomment-18624576.

AvdN commented 11 years ago

I will issue a new request