search

lihaoyi / macropy

Macros in Python: quasiquotes, case classes, LINQ and more!
3.28k stars 178 forks source link

clarify demo section of readme. #71

Closed rebcabin closed 9 years ago

rebcabin commented 9 years ago

Instantiate instructions from earlier 30,000-ft overview section. It's too easy to miss the important instructions if you zoom straight to the demo section as many readers will do.

rebcabin commented 9 years ago

I am not sure why the Travis tests are failing. Looks like a configuration issue and nothing to do with the actual unit tests. I don't think I have the access rights to repro this, let alone to fix it.

rebcabin commented 9 years ago

My remarks and assessment about "lazy copy-on-write" are incorrect, based on misunderstanding of the Python "==" operators (it doesn't test pointer equality; for that, I need the "is" operator).

I will amend the pull request over the weekend, but please disregard it for now.