search

lihaoyi / workbench-example-app

An example application written in ScalaJS using scala-js-dom and scala-js-workbench
204 stars 109 forks source link

Update sbt version #53

Closed shb closed 1 year ago

shb commented 6 years ago

Some 4 years after the last commit in the repository, it seems that the required rbt version 0.13.7 is nowhere to be found. To oldest sbt version known to https://www.scala-sbt.org is 0.13.15, while the latest in the 0.13.x series is 0.13.17. Setting the latter as the required sbt version inside project/build.properties fixes project's startup. SBT versions from 1.0.x seem not to work.

I guess this change would need to be merged in the other branches too.

mikemcgowan commented 6 years ago

SBT versions from 1.0.x seem not to work

sbt 1.2.3 works okay for me ...

shb commented 6 years ago

SBT versions from 1.0.x seem not to work

sbt 1.2.3 works okay for me ...

I didn't test versions that far actually. If newer versions really work the dependencies can updated accordingly, as long as they are updated.

I tested 0.13.17 to work (that is, not break the build process). Following semver versioning (which I assume the sbt package is following, but I may be wrong) this version should guarantee that no breaking changes get introduced.

Unfortunately I didn't test it further, neither I think I'll manage to do in the near future, so I'd rather leave this PR in the present state.