lihaoyi / workbench

Tooling around scala-js
234 stars 56 forks source link

Custom "updateBrowsers" JS code / callback #1

Closed sebnozzi closed 10 years ago

sebnozzi commented 10 years ago

It might be useful to be able to specify further steps to be done when trying to "update".

In the documentation you mention some things that are done/attempted. Some apps might require more specific steps to be performed (some DOM elements deleted, reloaded, etc.).

With such an option you'd give the user (developer) the power to adjust the JS reloading procedure to their needs.

(Disclaimer: I have not tried this project yet, just read the front-page documentation)

lihaoyi commented 10 years ago

I've been meaning to do this for some time; so it'll happen when I have the time/find the need for it =)

sebnozzi commented 10 years ago

Cool. I don't need it right now either. So I guess it's good that it's at least registered as an issue, waiting for its time to come ;-)

lihaoyi commented 10 years ago

Having thought about this further, I think everything you can possibly need is already available:

I think that basically covers all bases; even by default, the things you ask for (e.g. resetting the DOM) is already being done, and although it may make sense to customize it, that's already possible AFAICT.

sebnozzi commented 10 years ago

Makes sense.

lihaoyi commented 10 years ago

Closing this for now; have fun with the live reloading =)