* improvement: enable user to configure when workbench server should start

torstenrudolf commented 7 years ago

Up to now the workbench web server started whenever sbt was started. This is particular annoying when having a multi-project setup. In order to work properly, one needs to start the frontend project first, before starting the backend, otherwise workbench won't work properly.

With this change, you can enable the workbench plugin only for the frontend project (which was possible previously, but didn't bring much, since the server still started anyway on sbt load), and have it only started when running sbt "~frontend/fastOptJS".

The three settings are:

start the server on sbt startup, eg when starting the sbt terminal (this is the default, so same as existing behaviour)
```
workbenchStartMode := WorkbenchStartModes.OnSbtLoad
```
start the server on compilation (eg only when running sbt "~fastOptJS")
```
workbenchStartMode := WorkbenchStartModes.OnCompile
```
start the server manually using the startWorkbenchServer task
```
workbenchStartMode := WorkbenchStartModes.Manual
```

ochrons commented 6 years ago

Hey, workbench got updated to SBT 1.0 and in the process this PR resulted in some (minor) conflicts. If you can resolve the conflicts, we can include this in the upcoming Workbench release. Thanks!

ochrons commented 6 years ago

I retargetted this to a different branch (for sbt 0.13 compatibility)

ochrons commented 6 years ago

Functionality merged into the sbt 1.0 version, too.

torstenrudolf commented 6 years ago

sweet, thanks otto!

lihaoyi / workbench

* improvement: enable user to configure when workbench server should start #36