search

lihaoyi / workbench

Tooling around scala-js
234 stars 56 forks source link

Support spray's compressResponseIfRequested ? #39

Closed hgoldwire closed 6 years ago

hgoldwire commented 7 years ago

Hey gang,

My fastopt bundles are pretty big, and I serve them to remote clients for \<various reasons>.

What do you think about enabling spray's compressResponseIfRequested to compress responses when possible?

Probably right before here.

sjrd commented 7 years ago

workbench is not meant to be a production environment. It's a development cycle tool. You should configure your production server however you see fit.

hgoldwire commented 7 years ago

Of course, and in my development cycle I have two reasons for exposing my dev env on the internet at a known address:

1) ad-hoc collaboration with remote developers, e.g. conveniently show problems, share work-in-progress wo publishing artifacts somewhere, etc.

2) support oauth against an application where the identity provider is quite strict about where I can redirect (i.e. not localhost, https mandatory)

Exposing workbench (proxied by ngrok) is an extremely convenient solution--except for how sending uncompressed responses takes a lot longer than it could. Indeed, this "Accept-Encoding" header suggests compression was considered at some point, and it would make life a lot nicer for those of us collaborating across skinny pipes.