lihaoyi / workbench

Tooling around scala-js
234 stars 56 forks source link

Fix issue #45 #46

Closed hung-phan closed 6 years ago

hung-phan commented 6 years ago

This PR is an attempt to re-add host and port to Ajax request for notify workbench server. To be able to integrate workbench to other backend server like Play scala framework. We need the ability to define host and port for Workbench ajax request. Any idea?

ochrons commented 6 years ago

LGTM! I didn't quite realize there were use cases like this when I simplified the URL 😅

hung-phan commented 6 years ago

Hi 👋 @ochrons, thanks for merging my PR. When will you plan to release this change? I am currently have to point my code to github 😄 . Will love to be a 🐁 to use the new version

nafg commented 6 years ago

Any release planned?

hung-phan commented 6 years ago

You can just use this in the meantime

lazy val workbench = RootProject(uri("git://github.com/lihaoyi/workbench.git#75acf7d06cac7fe1798a585ee742005eac6d2ef9"))

lazy val root = (project in file(".")).dependsOn(workbench)

in plugins.sbt

nafg commented 6 years ago

Thanks. Is it a big deal to put a new version out though?

On Sun, Mar 18, 2018 at 11:55 PM Hung Phan notifications@github.com wrote:

You can just use this in the meantime

lazy val workbench = RootProject(uri("git://github.com/lihaoyi/workbench.git#75acf7d06cac7fe1798a585ee742005eac6d2ef9"))

lazy val root = (project in file(".")).dependsOn(workbench)

in plugins.sbt

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lihaoyi/workbench/pull/46#issuecomment-374094329, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGAUNUsIyyz8Wfjsa7jkTeSm5HGnbFUks5tfyxHgaJpZM4RJYBC .

nafg commented 6 years ago

Please release

ochrons commented 6 years ago

0.4.1 now released!

nafg commented 6 years ago

Thanks!