search

lihka1202 / pe

0 stars 0 forks source link

Excessive code provided #17

Open lihka1202 opened 1 year ago

lihka1202 commented 1 year ago

image.png

In this snippet, the code that has been provided is far too complex and verbose and may not be necessary for this DG. It would have been better to abstract this out into a method instead, and reference that method.

nus-se-script commented 1 year ago

Team's Response

This is just 1 line of regex, in the Developer guide which is intended for Developers.

This was included to aid understanding for Developers to help them understand the use of regex better.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This 1 line of regex adds no extra value to the developer guide and makes the explanation of the addStatement functionality unnecessarily verbose. None of the other parts of the Developer Guide dives this deep into a particular detail.