Open lihka1202 opened 1 year ago
This is done delibrately to improve readability, as having an 8-digit number with 2 decimal places without commas will make it difficult to read clearly. Ultimately, this is an aesthetics issue and there is no clear winner in terms of the best way to present it.
Team chose [response.Rejected
]
Reason for disagreement: Based on the code snippets above, Im using the same ones.
When I entered the following command:
add -out food $67
Done! Added: out for food, -$67.00, in category miscellaneous on 14/04/2023
I received an appropriate response. However, when I entered the same command and replaced 67 with 21,474,836.47, I get the following result.
add -out food $21,474,836.47
Sorry, your add command is invalid. Add format is as follows:
add [-in/-out] [description] $[value] {-c category} {-date DD/MM/YYYY}
Please refer to 'help' for more information!
Since I merely replaced the values, and the command with 67 is considered valid, it doesn't make sense for the command listed above to be invalid. Hence I made the claim that the error message displayed has an error. Since the format of the command is right, just that the format of the value is wrong, and this is what needs to be pointed out to the user.
Based on the interaction with the program:
This format is appropriate when adding stuff into the inventory
if the amount is exceeded:
This is the error, however if the value of 21,474,836.47 is added, the programs flags this output to be inappropriate
Which is an issue internally, and the error message is displaying the wrong information