lihongguang00 / pe

0 stars 0 forks source link

Invalid command format #6

Open lihongguang00 opened 10 months ago

lihongguang00 commented 10 months ago

Hi, it seems that when I do delete 300000000, the error message seems to be correct but when I do delete 3000000000 (extra 0), the error message changes to invalid command format instead. Perhaps this is due to overflow and maybe this overflow could be caught and handled so both throws the same error message?

Screenshot 2023-11-17 at 4.42.03 PM.png

Screenshot 2023-11-17 at 4.42.10 PM.png

soc-pe-bot commented 10 months ago

Team's Response

Extreme input

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Input is a non-zero unsigned integer, but not accepted! Error message is not correct!

Screenshot (314).png


[original: nus-cs2103-AY2324S1/pe-interim#3040] [original labels: type.FunctionalityBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

As seen from the screenshot of the course website, problems in case of deliberate sabotage should not be considered a bug. A typical user would not input such a large number for the index as they would never reach such a large number of patients.

Furthermore, even if such input is entered by a user mistake, it does not cause harm and in such a case, the user would be able to clearly see the error. However, we acknowledge the error message can be handled better and hence choose to respond with NotInScope.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]