liinnjohansson / todays-lunch

0 stars 1 forks source link

13 add map icons to map #37

Closed eminamuratspahic closed 3 years ago

eminamuratspahic commented 3 years ago

Close #13 I created a new file in data-map to style the map. There we can switch-of the already existing markers so now the map is just a blank screen with no other marker of stores and so on.

Added function to map every stored bistro in BistroContext as a marker in the map. Also added so when the user press a marker the marker should change. The functions are working in my ios unit. Please confirm that it's working on android.

(NOTE: Now the data is fetched from BistroContext, we have another issue that MapContext should be created so in that case the data should fetch data from that context instead. Something to discuss about?)

Regarding the styling on the markers, I think that we together should decide the sizes on them. It is hard for me to decide what is best. So I think that it should be an upcoming later design issue.

The marker is put in a tag hence to better functionality when it comes to change the CSS.

Question to the group: noticed when I structured my code that we don't have the same way in how to export the functions. In some files, it is export default function function-name and in some others, the export was put at the very last row.

EmelieBrobergs commented 3 years ago

image image

On my Android emulator the map doesn't work, but on my phone I can see the map!

EmelieBrobergs commented 3 years ago

image

Better size on icons! But the problem still occurs on my android phone (Huawai P30) regardin size of clicked icon.

EmelieBrobergs commented 3 years ago

image

Looks good!!