search

liip / LiipFunctionalTestBundle

Some helper classes for writing functional tests in Symfony
http://liip.ch
MIT License
640 stars 181 forks source link

[2.x] Add code checks #468

Open alexislefebvre opened 6 years ago

alexislefebvre commented 6 years ago

Add jobs in Travis CI for:

Code analysis is fast but having two different jobs will make results easier to read if there's an error.

We could rely on Docker image https://github.com/jakzal/phpqa instead of adding dependencies to dev.

Some ideas for the configuration of these tools:

Assigned to @Jean85

Jean85 commented 6 years ago

Why you don't want to rely on require-dev? IMO it's hard for contributors later, since they have to run additional commands to run the checks locally...

alexislefebvre commented 6 years ago

Using Docker was a suggestion. You're right, it's easier to install analysis tools with Composer.

Jean85 commented 6 years ago

I was trying to work on this but it seems a big mess: we have too many dev dependencies which I cannot skip or the analysis will fail, and at the same time PHPCR doesn't allow PHPUnit 7, which is required to use phpstan/phpstan-phpunit...

It seems to me that we're having too many optional dependencies in this package. Maybe we should split them?

alexislefebvre commented 6 years ago

we have too many dev dependencies which I cannot skip or the analysis will fail

Could you please explain this? What is failing?

About PHPCR, we may drop it from this bundle, there have been no issue about PHPCR during five years, maybe it's not used much.

Jean85 commented 6 years ago

PHPStan requires all used dependencies to be installed because it need to know all symbols used in our code.