search

liip / LiipFunctionalTestBundle

Some helper classes for writing functional tests in Symfony
http://liip.ch
MIT License
639 stars 182 forks source link

Symfony 5 support #556

Closed gregurco closed 4 years ago

gregurco commented 4 years ago

Hello,

here are changes to support Symfony 5.

Resolves: #554 Closes: #555

alexislefebvre commented 4 years ago

That looks great!

gregurco commented 4 years ago

Hello @alexislefebvre Today I plan to test these changes with project migrating from SF4 to SF5. I will write the result after the test.

gregurco commented 4 years ago

@alexislefebvre could you help me with next error?

There was 1 failure:

1) Liip\Acme\Tests\Command\ParatestCommandTest::testParatest
Failed asserting that 'Error : Install paratest first\n' contains "Running phpunit in 3 processes with vendor/bin/phpunit".

/home/travis/build/liip/LiipFunctionalTestBundle/tests/Command/ParatestCommandTest.php:50

I see that paratest is not installed in dev. How tests worked before? Should it be installed or somehow mocked in tests?

alexislefebvre commented 4 years ago

I was stuck too with paratest in #555

I haven't checked yet how much effort are required to support paratest and Symfony 5 in the same time.

Feel free to remove the paratest test in this PR, so we can merge it and then publish a new unstable release. We'll evaluate the case of paratest later.

gregurco commented 4 years ago

@alexislefebvre good idea! Done! I also will check how to fix integration with paratest.

alexislefebvre commented 4 years ago

Thanks for the great work!

Here is an alpha release with these changes: https://github.com/liip/LiipFunctionalTestBundle/releases/tag/3.4.0-alpha1