search

liip / LiipFunctionalTestBundle

Some helper classes for writing functional tests in Symfony
http://liip.ch
MIT License
640 stars 180 forks source link

PHP 8 support #577

Closed ndench closed 3 years ago

ndench commented 3 years ago

Pretty much just copied liip/LiipTestFixturesBundle#80.

Closes: #575

ndench commented 3 years ago

Runs fine on 8.0 with Symfony 4.4. But gets version conflicts for 3.4 and 4.4. Not really sure on how we should solve this.

alexislefebvre commented 3 years ago

Feel free to remove Symfony 3.4 and the --prefer-lowest option.

And the test with PHPUnit 7.5 too. :slightly_smiling_face:

alexislefebvre commented 3 years ago

If you rebase on master, please add PHP 8.0 in that file: https://github.com/liip/LiipFunctionalTestBundle/blob/99773a1d732fcd691ab88440d49548ee378b5d47/.github/workflows/tests.yml

ndench commented 3 years ago

Thanks @alexislefebvre, I've made those changes and now it passes :smile:

alexislefebvre commented 3 years ago

Awesome, thanks!

alexislefebvre commented 3 years ago

Here is a new release: https://github.com/liip/LiipFunctionalTestBundle/releases/tag/4.3.0