Closed magnetik closed 2 years ago
Thanks for the PR.
Tests with Symfony 6 should be green if you add Symfony 6 in .github/workflows/tests.yml
.
The new config for security will work on Symfony 6 but not the older versions. If we can't find a way, we could load different config files in AppKernel
, depending on the version of Symfony.
Hi @magnetik, what is the status of this PR? Is it already finished, or do you need help>
Hi @magnetik, does @alexislefebvre solution solved your problems ? Have this package available for SF6 will be great.
Can somebody with permissions rerun the tests so we can see what is failing? The current logs are not being shown since a lot of time has passed since the actions were run.
I can't rerun these jobs.
In order to have the errors, I opened another PR from this one: #603
The current issue is that framework.session.storage_factory_id
replaces framework.session.storage_id
since Symfony 6.0 (deprecated in 5.3), we have to read 2 different config files.
One test of AllowedQueriesExceededException
and some other things were broken on the main branch, I fixed these issues in another PR: #604 I'm not happy with the change of max_query_count
from 1
to 0
in the internal tests but if it allow to have a version compatible with Symfony 6, it will be worth it.
If you're interested in Symfony 6, please review #603
Dear users, what methods from this bundle do you use? Which ones would you like to still use with Symfony 6?
This was merged in #603, thanks @magnetik !
Trying to make this bundle compatible with Symfony 6
ref #597