search

liip / LiipFunctionalTestBundle

Some helper classes for writing functional tests in Symfony
http://liip.ch
MIT License
641 stars 182 forks source link

allow doctrine/annotations 2 #613

Closed alexislefebvre closed 1 year ago

alexislefebvre commented 1 year ago

Fixes #612

alexislefebvre commented 1 year ago

Should this dependency be not mandatory?

Nirator78 commented 1 year ago

In the liip library you are using it only in the class QueryCounter

alexislefebvre commented 1 year ago

Yes, the bundle may not require doctrine/annotations because some users won't use QueryCounter.

Nirator78 commented 1 year ago

So what we can do ? Delete the doctrine/annotations on the LiipFunctionalTestBundle or resolve the test to allow upgrade on the library ?

alexislefebvre commented 1 year ago

I had to force doctrine/annotations v1 on PHP 7.* otherwise the CI failed, we'll check this later.