liip / LiipFunctionalTestBundle

Some helper classes for writing functional tests in Symfony
http://liip.ch
MIT License
641 stars 182 forks source link

Symfony 7 compatibility #630

Closed kl3sk closed 6 months ago

kl3sk commented 6 months ago

Is your feature request related to a problem? Please describe. No upgrade to SF 7 possible

Describe the solution you'd like Upgrade to SF 7

Describe alternatives you've considered Downgrade to SF 6.4

Thanks

alexislefebvre commented 6 months ago

Thanks for the report.

We can take inspiration from:

kl3sk commented 6 months ago

Hello @alexislefebvre

Yes, I get the impression that it's not a huge job. Thank you for considering this question.

Sincerely

alexislefebvre commented 6 months ago

Free free to open a Pull Request with the required changes.

kl3sk commented 6 months ago

Ok why not, I'll have a look.

Edit: I forgot that I had forked it yesterday to try 😝

kl3sk commented 6 months ago

Here is a proposal: https://github.com/liip/LiipFunctionalTestBundle/pull/631

alexislefebvre commented 6 months ago

Could you please tell us what methods of this bundle are used in your projects? Some methods have been integrated in Symfony.

kl3sk commented 6 months ago

Crap ! You nailed it, none seems to be used any more.

I'll remove the bundle from my project and try some tests that pass 🙄

kl3sk commented 6 months ago

Because I was writing functional tests I though this bundle was used,

But it is LiipTestFixturesBundle that is used. And seems already ready for Sf7.

My bad.

Nirator78 commented 6 months ago

Hi, I'm currently using LiipFunctionalTestBundle in my Symfony 6.4 and i can't update in Symfony 7.0 because LiipFunctionalTestBundle is not compatible.

Your requirements could not be resolved to an installable set of packages. Problem 1

  • Root composer.json requires liip/functional-test-bundle 4.10.0 -> satisfiable by liip/functional-test-bundle[4.10.0].
    • liip/functional-test-bundle 4.10.0 requires symfony/browser-kit ^4.4 || ^5.1 || ^6.0 -> found symfony/browser-kit[v4.4.0, ..., v4.4.44, v5.1.0, ..., v5.4.31, v6.0.0, ..., v6.4.0] but it conflicts with your root composer.json require (7.0.*).
alexislefebvre commented 6 months ago

@Nirator78 Could you please tell us what methods of this bundle are used in your projects? Some methods have been integrated in Symfony.

See also:

alexislefebvre commented 6 months ago

Please try the last release: https://github.com/liip/LiipFunctionalTestBundle/releases/tag/4.11.0

Nirator78 commented 6 months ago

I'm actually using the makeClient method and the assertStatusCode method.

alexislefebvre commented 6 months ago

I'm actually using the makeClient method and the assertStatusCode method.

The documentation has been updated to show that built-in functions from Symfony can be used: https://github.com/liip/LiipFunctionalTestBundle/blob/f8e0bd27591ef804cf2c33ee144fedac2e1b1194/doc/basic.md

Nirator78 commented 6 months ago

Thank i will try this.