liip / LiipImagineBundle

Symfony Bundle to assist in image manipulation using the imagine library
http://liip.ch
MIT License
1.66k stars 378 forks source link

return values from the aws client are not used #1461

Closed dbu closed 2 years ago

dbu commented 2 years ago
Q A
Branch? 2.x
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fix #1456, fix #1451
License MIT
Doc -

no need to mock the response from the AWS client, and then no need to have a mock guzzle model class in the test fixtures

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 85.406% when pulling 78ba9b8995b9dbd31761eb0d1ca16e2cd4aca18a on remove-guzzle-return-mock into a77cd625a15db32065181d47cfda658c1645b08a on 2.x.