liip / LiipImagineBundle

Symfony Bundle to assist in image manipulation using the imagine library
http://liip.ch
MIT License
1.66k stars 378 forks source link

Clarify/Document Flysystem Bundle Dependency (oneup,thephpleague) #1477

Closed tacman closed 2 years ago

tacman commented 2 years ago

According to the documentation (https://symfony.com/bundles/LiipImagineBundle/current/data-loader/flysystem.html), there's a soft dependency on https://github.com/1up-lab/OneupFlysystemBundle.

This cache resolver has a soft dependency on OneupFlysystemBundle, which can be installed by executing the following command in your project directory:

  composer require oneup/flysystem-bundle

Will this bundle also work with Flysystem's Bundle (https://github.com/thephpleague/flysystem-bundle?

Describe the solution you'd like

I think that this bundle will work with either flysystem bundle, and was hoping to see an example, and if that's true, see this reflected in the documentation.

dbu commented 2 years ago

thanks for bringing this up. indeed it should work just fine with the league bundle - all we care about is having a flysystem instance as a symfony service, and either bundle provides that. you could even define the flysystem service without a bundle if you would prefer (though the bundles provide a much nicer way to do that).

dbu commented 2 years ago

i updated the documentation to explain this.

tacman commented 2 years ago

Thanks. By any chance, is there a simple symfony demo that shows implements this?

I've updated Ryan's All About Uploads to Symfony 6 (https://github.com/tacman/uploads-finish), but am still fighting with the configuration. A simple "upload a photo, then show it cropped and get the url from a cache so it doesn't have to hit aws s3".

dbu commented 2 years ago

the documentation is here: https://symfony.com/bundles/LiipImagineBundle/current/cache-resolvers.html

i am not aware of a current demo application with the imagine bundle, sorry.

tacman commented 2 years ago

Can you update this page to reflect how to configure the bundle without oneup?

https://symfony.com/bundles/LiipImagineBundle/current/data-loader/flysystem.html

On Tue, Aug 2, 2022 at 2:22 AM David Buchmann @.***> wrote:

the documentation is here: https://symfony.com/bundles/LiipImagineBundle/current/cache-resolvers.html

i am not aware of a current demo application with the imagine bundle, sorry.

— Reply to this email directly, view it on GitHub https://github.com/liip/LiipImagineBundle/issues/1477#issuecomment-1202066869, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXIQLDVGF6XWDA6X24EKTVXC5AVANCNFSM55DA5LTA . You are receiving this because you authored the thread.Message ID: @.***>

dbu commented 2 years ago

symfony.com only pulls the changes a couple of times a day. it updated meanwhile.