search

liip / LiipImagineBundle

Symfony Bundle to assist in image manipulation using the imagine library
http://liip.ch
MIT License
1.66k stars 378 forks source link

Deprecated $defaultName property in commands #1488

Closed garak closed 2 years ago

garak commented 2 years ago

The $defaultName property in commands has been deprecated in Symfony 6.1

Commands in Symfony 6 should use the AsCommand attribute instead. A possible workaround to keep compatibility with older PHP versions is using the getDefaultName method instead.

dbu commented 2 years ago

yeah, i think to use the attribute we would have to drop php 7 support and also some of the older symfony versions. symfony 7 is still about 1 year in the future, we can either ignore it until we need to do something for symfony 7 support and then drop old versions, or go with the getDefaultName for now and then change again later. i would tend to ignore for now, its a deprecation but not creating any problems.

but if you want to do a pull request to change it, i can review and merge it.

garak commented 2 years ago

Sorry, I just realized that this was already fixed in #1472 I guess that at this point we only need a new release... I see that the last one was last May, maybe it could be a good time?

dbu commented 2 years ago

right, thanks for the reminder: https://github.com/liip/LiipImagineBundle/releases/tag/2.9.0