search

liip / LiipImagineBundle

Symfony Bundle to assist in image manipulation using the imagine library
http://liip.ch
MIT License
1.66k stars 378 forks source link

Add return types to silence Symfony 6.3 deprecations #1514

Closed mbabker closed 1 year ago

mbabker commented 1 year ago
Q A
Branch? 2.x
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets N/A
License MIT
Doc N/A

Symfony 6.3 added a number of return types to the framework. This PR should cover all the ones that popped up when beta testing an application.

Because all affected classes are non-final/internal, doc block annotations are used.

coveralls commented 1 year ago

Coverage Status

Coverage: 79.901%. Remained the same when pulling 8b23f88e5768ae90d8899aaa9c0131f366b2de15 on mbabker:silence-symfony-6.3-return-type-deprecations into 9cc3fe6f408250fbc51f9cd0d89cb1214fa957bf on liip:2.x.

mbabker commented 1 year ago

thanks. i would prefer to add actual return type declarations as the compiler passes are not extension points.

Updated

dbu commented 1 year ago

https://github.com/liip/LiipImagineBundle/releases/tag/2.11.0