Closed wouterSkepp closed 1 year ago
i will fix the cs failures in the 2.x branch to be clean there.
i will fix the cs failures in the 2.x branch to be clean there.
the 2.x branch is green again. please rebase your branch on 2.x
Thank you for your helpful review! Updated PR accordingly.
i am not super sure if the path / resolvedPath are always the file path or if they can be the cache path as well.
I've not done a deep dive into the caching mechanism, but according to https://github.com/liip/LiipImagineBundle/blob/2.x/Resources/doc/asset-versioning.rst?plain=1#L10-L19 and from what I've seen so far is that this is always the original filepath.
i rebased and squashed the commits in #1529
This PR adds in support for JsonManifestVersionStrategy that is available in Symfony. In a JSON manifest, we have a key => value structure where the key is the original filepath, and the value the versioned filestring, e.g:
Similar to
StaticVersionStrategy
that loads it's configuration from the container, this reads the JSON Manifest file definedThe LazyFilterRuntime has been extended to load the JSON Manifest file contents, and the various methods within to handle both Static & Json versioning.
Note that the current 2.x branch has unrelated failing CI.
I don't think this PR breaks current implementations although test coverage for AssetsVersionCompilerPass currently is lacking.