search

liip / LiipImagineBundle

Symfony Bundle to assist in image manipulation using the imagine library
http://liip.ch
MIT License
1.66k stars 378 forks source link

Drop support for unsupported dependencies in v3 #1548

Open tacman opened 10 months ago

tacman commented 10 months ago

Let's drop all support for anything EOL in version 3. In fact, I'd like to see V3 only support Symfony 6.4 || ^7.0, and skip 5.4 (since anyone on 5.4 can still use v2).

Twig 2 just published its last release, so in V3 I think we should just support V3 of twig.

Ditto for old versions of PHP.

Is 3.0 of this bundle okay to use in a production environment, at least for all the v2 features?

dbu commented 10 months ago

i agree, we should cleanup up a lot here.

version 3.x did not diverge all that much from 2.x yet, so i don't expect bugs or broken things.

but i hope we can do some more cleanups that might lead to BC breaks - so using the 3.x branch might be bumpy when upgrading dependencies.

notably with issues like #1523 and many people with problems with paths, i would love to cleanup how we handle the paths (and fix the naming to be easier to understand). it should be simple to understand when its about storing the source image somewhere, when about storing a cached image and when its the url to load the image in a browser. i also hope that we can ditch some of the code for supporting various storage solutions in favor of just league/flysystem for everything beyond the local filesystem. or maybe even hard depend on flysystem and use it for local files too.

tacman commented 10 months ago

Well, that'd be great. As I mentioned elsewhere, dropping OneUp would make documentation much easier.

I think my situation is probably pretty common -- I develop with a local filesystem, and occasionally with S3, then I deploy to production with S3. This works well once it's set up, but setting it up the first time was confusing for me.