Add aliases for manager services for improved autowiring support

liip / LiipImagineBundle

Symfony Bundle to assist in image manipulation using the imagine library

http://liip.ch

MIT License

1.66k stars 378 forks source link

Add aliases for manager services for improved autowiring support #1554

Closed mbabker closed 9 months ago

mbabker commented 10 months ago

Q	A
Branch?	2.x
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Fixed tickets	N/A
License	MIT
Doc	N/A

The liip_imagine.cache.manager, liip_imagine.data.manager, and liip_imagine.filter.manager services cannot be autowired at present, requiring folks to either manually create aliases in their app's configuration or to use one of the newer dependency injection attributes to specify the right service in their classes. This PR adds the appropriate service aliases to support autowiring and remove that little bit of extra overhead needed to use these three services.

coveralls commented 10 months ago

coverage: 81.998%. remained the same when pulling 63d9dbab513018cbadef639ea67c13721d88eb35 on mbabker:autowiring-aliases into 1d42ed1edb41a64514a287c7ea6c4d895b0220dc on liip:2.x.

mbabker commented 9 months ago

can you please also update the documentation of the corresponding services?

Sorry, I forgot all about this ask with the way things have gone for me over the last several weeks. I'll try to throw a PR together for the docs soon.

dbu commented 9 months ago

no worries. i also forgot and just noticed now. i adjusted the doc in 13be8f6810407a34241c1efe6ffcbded4f3efc39

i want to cleanup rather radically for 3.x, i think no further doc refinement for the 2.x is needed now.

and thanks for the contribution.