search

liip / LiipImagineBundle

Symfony Bundle to assist in image manipulation using the imagine library
http://liip.ch
MIT License
1.66k stars 378 forks source link

JsonManifestStrategy, support for FormatExtensionResolver #1588

Closed wouterSkepp closed 5 months ago

wouterSkepp commented 5 months ago
Q A
Branch? 2.13
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #1524
License MIT
Doc

Apologies, this got very stale. My initial PR that resulted in https://github.com/liip/LiipImagineBundle/pull/1529 was not supporting format changes; If a filter was to convert a jpg to webp, then the versioned asset would still be served with the .jpg extension.

When applying the FormatExtensionResolver, this is now handled. Versioned JSON manifest assets get their extension swapped as well.

I've bumped the target version to 2.13.

dbu commented 5 months ago

thanks a lot for picking this up. there are conflicts (and the diff shows the changes already in #1529). can you squash the commits and rebase on json_manifest_version_strategy_support and solve conflicts? then it will be visible what actually changes in this pull request.

wouterSkepp commented 5 months ago

thanks a lot for picking this up. there are conflicts (and the diff shows the changes already in #1529). can you squash the commits and rebase on json_manifest_version_strategy_support and solve conflicts? then it will be visible what actually changes in this pull request.

Thank you, done