Drop support for PHP 5.x and update travis config

[kbond]

Looks like the prefer-lowest problem was caused by https://github.com/composer/composer/issues/5355

This config has been adapted from the FOSUserBundle.

[lsmith77]

memory limit needs to be increased ..

[lsmith77]

- echo "memory_limit=-1" >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini

[kbond]

Yeah, just pushed this.

[kbond]

Yikes, travis is killing the process now. I think the dep graph for this bundle is really complex

[kbond]

I tried disabling xdebug but this removes code coverage. If this works I can look at enabling after the composer update.

[kbond]

@stof, can you take a look at this one? I based the travis config on FOSUserBundle.

[lsmith77]

FYI https://twitter.com/lsmith/status/1012210458101796865?s=21

[lsmith77]

sigh .. now getting segmentation faults https://travis-ci.org/liip/LiipMonitorBundle/jobs/398211959

so maybe the best thing we can do .. disable xdebug, and therefore code coverage, for all versions below 7. wdyt?

[kbond]

Those tests that caused the segfault had xdebug disabled.

[lsmith77]

ah doh .. but they still attempt to collect code coverage ..

at any rate .. maybe lets just kill 5.6 testing (and support?) http://php.net/supported-versions.php

[kbond]

but they still attempt to collect code coverage ..

I think that is just a warning from phpunit.

Why don't we just kill 5.x testing for now.

[stof]

if you do drop testing, please also drop support for it in composer.json. Advocating support for a PHP version without testing it is bad, because composer will be told that it is compatible, while you have no clue about it (any future PR might break the compat without you knowing it). bumping the min version would make composer use an older tested version instead.

[kbond]

Ok, so we can drop 5.x support in a 2.7.0 release of this bundle (don't need a major version jump)?

[lsmith77]

sound good to me!

[kbond]

v1.2 of zend diagnostics dropped support for guzzle 3/4

[kbond]

@lsmith77 we should do one last 2.6.8 release before merging this

[kbond]

I'm having trouble tracking down the latest failure.

[lsmith77]

what do you think should go into 2.6.8?

atm we just have the new memcached check in master which imho could just as well only go to 2.7.0 from my point of view: https://github.com/liip/LiipMonitorBundle/compare/2.6.7...master

[lsmith77]

for the error .. I think its caused by the fact that its installing TwigBundle 2.0.7

[kbond]

It's a game of wak-a-mole. Fix TwigBundle and another problem pops up... Only fixes I can think of is:

1. a bunch of dev requirements preventing lower versions of components...
2. go back to requiring symfony/symfony before tests instead of symfony/lts

I'm leaning towards (2).

[lsmith77]

or maybe we just decide to only 3.4+ in master .. as @Tobion suggested in the routing PR

[kbond]

I still had the same issue - some components are coming in at 2.x and causing issues.

[kbond]

Bah, I tried requiring symfony/lts:^3 when using --prefer-lowest but caused the build to hang.

[kbond]

Any chance we can remove --prefer-lowest? :wink:

[lsmith77]

interesting https://travis-ci.org/liip/LiipMonitorBundle

[kbond]

I tried prefixing the composer install command with travis_wait (https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received). Should give us 20 minutes now to resolve deps.

Edit: this did not work :disappointed:

[lsmith77]

the question is .. are we running into these issues because of the changes to composer.json or .travis.yml ? if its the later .. then lets just revert them ..

[lsmith77]

ok looks better now .. the cause of the failures are

1) Liip\MonitorBundle\Tests\Helper\PathHelperTest::testGenerateRoutes
Twig_Error_Runtime: The "core" extension is not enabled.

[kbond]

Finally. I had to force Symfony 3.1+. I guess I should update composer.json to match?

[kbond]

Ok, this should be good to go.

[lsmith77]

awesome! .. so I guess I will release 2.7.0 based on this