search

liip / LiipMonitorBundle

Integrates the LiipMonitor library into Symfony
http://liip.ch
467 stars 103 forks source link

Add reporters endpoint #206

Closed AyrtonRicardo closed 5 years ago

AyrtonRicardo commented 5 years ago

This endpoint it's helpful in our case because we have different team working in that "integration and monitoring", to see the documentation in this way is better and easy to maintain, because in every implementation we need to implement the same endpoint only to display this default route.

Also fixed the documentation where was missing the property "globalStatus".

lsmith77 commented 5 years ago

looks alright to me @kbond .. wonder if adding this endpoint is a security issue since it might expose things that people currently would not want to expose? then again they should look at the changelog and adjust routing if needed.

kbond commented 5 years ago

Hmm, this would (I believe) make the http api fully in sync with the monitor:list and monitor:health commands. I don't know that exposing the alias' of custom reporters would be a security issue... That being said, I'm certainly not a security expert...

lsmith77 commented 5 years ago

it would just leak some information that is included in the name .. but I guess not more than the current end point does already.