search

liip / LiipMonitorBundle

Integrates the LiipMonitor library into Symfony
http://liip.ch
467 stars 103 forks source link

Make the HTTP failure status code configurable. #214

Closed tobz closed 5 years ago

tobz commented 5 years ago

This PR is an implementation of #213. As discussed, the value is set to have the default be the existing 502 value.

Questions of mine: looks like there's no existing test for the controller... should there be?

kbond commented 5 years ago

Looks like the parameter is not being set (this is why the test is failing). Should set around here: https://github.com/liip/LiipMonitorBundle/blob/7a3bc243a4a8a4af5e17a7f7441dfe1f53bc30cf/DependencyInjection/LiipMonitorExtension.php#L65

As for the tests, would be nice but won't hold you to adding them before merging.

tobz commented 5 years ago

Ah great... I ran phpunit locally but it seemed to pass. Glad the CI caught my mistake. Will fix!

kbond commented 5 years ago

Looks good, @lsmith77, any objections?

lsmith77 commented 5 years ago

fine for me

kbond commented 5 years ago

tagged 2.9.0

tobz commented 5 years ago

Thanks all!