liip / LiipMonitorBundle

Integrates the LiipMonitor library into Symfony
http://liip.ch
467 stars 103 forks source link

cannotBeEmpty on arrayNode is deprecated in symfony 3 and removed in 4 #216

Closed JMLamodiere closed 5 years ago

JMLamodiere commented 5 years ago

Here is the warning when using symfony 3.4 :

Using Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition::cannotBeEmpty() at path "liip_monitor.mailer.recipient" has no effect, consider requiresAtLeastOneElement() instead. In 4.0 both methods will behave the same.

See symfony source code, it's a @trigger_error in sf3 and an exception in sf4 :

A similar fix can be viewed in another bundle : https://github.com/nelmio/NelmioJsLoggerBundle/pull/20

kbond commented 5 years ago

Thanks @JMLamodiere, I did notice this the other day.