search

liip / LiipMonitorBundle

Integrates the LiipMonitor library into Symfony
http://liip.ch
467 stars 103 forks source link

Feature: lazy load checks on monitor dashboard #223

Closed berezuev closed 4 years ago

berezuev commented 4 years ago

Feature: lazy loading of checks on frontend.

w/o lazy loading: before_small with lazy loading (gif is freezing. In real life it looks smoother): after_small

berezuev commented 4 years ago

@kbond WDYT?

kbond commented 4 years ago

Looks good @berezuev - can you make it opt-in?

Or do you think it should be the default? Will it work in all browsers?

berezuev commented 4 years ago

@kbond, I've made it optional, but set parameter true by default. I think, it would work in all actual browsers.

Not sure about documentation, English is not my native language. Can you check it, please?

kbond commented 4 years ago

@lsmith77 what do you think of this? Specifically making it the default? I don't use the frontend provided in this bundle for any projects so I'm apprehensive about merging. Do you know anyone who uses it that could review?

lsmith77 commented 4 years ago

as long as its configurable its fine for me.

kbond commented 4 years ago

Thanks @berezuev!

kbond commented 4 years ago

Released in 2.11.0

berezuev commented 4 years ago

@kbond I'm really sorry, but i think, you'd better revert this. I've been testing it using php dev server (php -S), and now I've tried in on nginx+php-fpm. Flushing echo doesn't work properly there (because of caching, gzipping, etc).

kbond commented 4 years ago

No problem, I reverted in #225