search

liip / LiipMonitorBundle

Integrates the LiipMonitor library into Symfony
http://liip.ch
467 stars 103 forks source link

Fix ListChecksCommand for Symfony 5 #224

Closed berezuev closed 4 years ago

berezuev commented 4 years ago

Symfony 5 commands MUST return exit code in execute() method. If it doesn't return int, TypeError throws.

From Symfony Console docs:

Deprecated since version 4.4:Not returning an integer with the exit status as the result of execute() is deprecated since Symfony 4.4.

kbond commented 4 years ago

What's the reason for catching exceptions?