liip / LiipMonitorBundle

Integrates the LiipMonitor library into Symfony
http://liip.ch
467 stars 103 forks source link

BC break switching to laminas/laminas-diagnostics #231

Closed ndench closed 4 years ago

ndench commented 4 years ago

When switching to Laminas Diagnostics there was a BC break for users who are defining custom reporters and extending the built in reporters. To fix the BC break, users merely need to update the their import statements:

- use ZendDiagnostics\Result\Collection as ResultsCollection;
+ use Laminas\Diagnostics\Result\Collection as ResultsCollection;
kbond commented 4 years ago

Damn.. the https://github.com/laminas/laminas-zendframework-bridge doesn't alias this?

ndench commented 4 years ago

Hmm yeah, that didn't seem to work. I'm not sure why though. After the composer update it got through our CI process fine but once it was deployed, the first time we hit the monitor endpoint for a health check we got an exception.

adonix commented 3 years ago

This bundle uses the security checker from sensioLabs, which is a dependency in the laminas-diagnostics bundle, however, the security-checker is no longer supported. Is there a fix for this? It is being recommended to use this an alternative. Anyone had luck with this?

kbond commented 3 years ago

Yep, this is being worked on: https://github.com/liip/LiipMonitorBundle/pull/258

adonix commented 3 years ago

@kbond thanks for the update 👍