search

liip / LiipMonitorBundle

Integrates the LiipMonitor library into Symfony
http://liip.ch
467 stars 103 forks source link

Replace root_dir with project_dir for security check #233

Closed jrjohnson closed 4 years ago

jrjohnson commented 4 years ago

kernel.root_dir was deprecated in symfony 4.2 and removed in Symfony 5.

Enabling the security_advisory check and running monitor:health in a fresh Symfony 5 app will result in 

The parameter "liip_monitor.check.security_advisory.lock_file.default" has a dependency on a non-existent parameter "kernel.root_dir". 

Did you mean one of these: "kernel.project_dir", "kernel.cache_dir" , "kernel.logs_dir"?

There are several usages of this in DependencyInjection/Configuration but the rest seemed to apply only to older Symfony project layouts so I left them alone.

kbond commented 4 years ago

Thanks @jrjohnson

tacman commented 1 month ago

root dir still appears in many places:

https://github.com/search?q=repo%3Aliip%2FLiipMonitorBundle%20root_dir&type=code