search

liip / LiipMonitorBundle

Integrates the LiipMonitor library into Symfony
http://liip.ch
467 stars 103 forks source link

Ping & ElasticSearch checks #265

Closed andriinavrotskii closed 2 years ago

kbond commented 2 years ago

Hey @andriinavrotskii! Thanks for the PR but I'm trying to see what this does that can't be done with the guzzle_http_service check.

For instance, I have an elasticsearch "ping" check configured as follows:

liip_monitor:
    checks:
        guzzle_http_service:
            search:
                url: "http://%env(SEARCH_HOST)%"
                content: "\"status\" : 200"
andriinavrotskii commented 2 years ago

Hey @andriinavrotskii! Thanks for the PR but I'm trying to see what this does that can't be done with the guzzle_http_service check.

For instance, I have an elasticsearch "ping" check configured as follows:

liip_monitor:
    checks:
        guzzle_http_service:
            search:
                url: "http://%env(SEARCH_HOST)%"
                content: "\"status\" : 200"

You are right. guzzle_http_service: elastic_search_client: url: 'http://%env(HOST)%:%env(PORT)%/_cluster/health/%env(INDEX)%?wait_for_status=yellow&timeout=1s'

kbond commented 2 years ago

Sorry, missed the Ping check. I'm also not understanding the purpose of it.

stale[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This pull request has been automatically closed. Feel free to re-create if it is still relevant.