liip / LiipMonitorBundle

Integrates the LiipMonitor library into Symfony
http://liip.ch
467 stars 103 forks source link

docs: add info on limit for OhDear #293

Closed Chris53897 closed 6 months ago

Chris53897 commented 6 months ago

https://github.com/liip/LiipMonitorBundle/pull/289#issuecomment-1868518201

kbond commented 6 months ago

Should we hard code the results limit to 50 so at least the first 50 run?

Chris53897 commented 6 months ago

Good idea. But OhDear can change this limit anytime.

kbond commented 6 months ago

Yeah that's true but right now, none run, correct? I guess we'll just need to update as required...

kbond commented 6 months ago

Did you hit this limit?

kbond commented 6 months ago

The alternative would be to throw an exception I guess. Force users to add to a suite that's size is less than 50. I'd be fine with that also.

Chris53897 commented 6 months ago

For now i would suggest to leave it as it is. As there are more important other tasks for me personally. I do not hit this limit.

kbond commented 6 months ago

Fine by me