search

liip / LiipThemeBundle

Provides theming support for Symfony bundles
MIT License
290 stars 76 forks source link

Translations (and public ressources) #12

Open skydiablo opened 12 years ago

skydiablo commented 12 years ago

What about Translations ? If i use another theme, i want to load another translation-file too! it is possible to regard this too ? or maybe some workarounds ?

greez, sky...

lsmith77 commented 12 years ago

hmm i would suggest to simply make the translation key dynamic

Koc commented 12 years ago

no way until this symfony/symfony#971 will be resolved

lsmith77 commented 12 years ago

i must admit i am a backend guy, so i don't know the entire translation stuff all that well.

skydiablo commented 12 years ago

hiho! some cognitions ?

lsmith77 commented 12 years ago

i currently do not have the intention to work on this .. i recognize that for theming other aspects might also be necessary .. so if someone cooks up a proposal i am willing to evaluate it.

Koc commented 12 years ago

I am propose change current directory structure to something like this

app
    Resources
        themes
            %theme_name%
                views
                public
                translations

this is BC-break, because now templates located directly at %theme_name% and after this cnahge would at %theme_name%/views. But this is very natural that theme has own public resources.

I can work on this issue if you approove this proposal.

Koc commented 12 years ago

So what do you think about my proposal?

lsmith77 commented 12 years ago

i am open to this change .. since added some flexibility in the order of directories, we might even be able to keep BC.

btw there is also https://github.com/Sylius/SyliusThemingBundle from which we might be able to draw some inspiration. IIRC the bundle was once even based on this bundle.

dirkluijk commented 10 years ago

+1 for including (public) assets as well.

A theme is more than just views, it would be great if any resource can live inside a theme.