search

liip / LiipThemeBundle

Provides theming support for Symfony bundles
MIT License
290 stars 76 forks source link

Change the way to inject ActiveTheme since Symfony 3.2.1 #159

Closed j0k3r closed 7 years ago

j0k3r commented 7 years ago

In Symfonny 3.2.1 a new parameter has been added to the TwigBundle FilesystemLoader breaking the LiipThemeBundle own FilesystemLoader. Instead of adding a 4th parameter, we define the service to call a method after being instanciated to define the ActiveTheme.

Related:

I don't know if this provide a BC break since we are changing the constructor definition..

wachterjohannes commented 7 years ago

we at sulu has also this problem when we try to upgrade to symfony3 and with this fix everything works fine with the this bundle.

lsmith77 commented 7 years ago

see https://github.com/liip/LiipThemeBundle/releases/tag/1.4.3