search

liip / LiipThemeBundle

Provides theming support for Symfony bundles
MIT License
290 stars 76 forks source link

Upgrade to phpunit 6 #172

Closed geecu closed 6 years ago

geecu commented 6 years ago

As suggested by @xabbuh in #171

On PHP 5.5 a test is failing because it expects it to throw a \PHPUnit\Framework\Error\Warning, which wasn't added (nor is it planned to) to phpunit@4.8's forward compatibility (related phpunit issue). I don't know how to move on about this...

lsmith77 commented 6 years ago

I would say lets just increase the minimal phpunit requirement ..

lsmith77 commented 6 years ago

superseded by #173

lsmith77 commented 6 years ago

@geecu I worked a bit on your changes and managed to resolve the issues

geecu commented 6 years ago

thanks