search

liip / LiipThemeBundle

Provides theming support for Symfony bundles
MIT License
290 stars 76 forks source link

cache:warm generates incorrect app/cache/[env]/templates.php #8

Closed lsmith77 closed 13 years ago

lsmith77 commented 13 years ago

It seems that the overriding of the template.locator isnt taken into account at this point yet, so the file is generated incorrectly. Maybe the file just needs to be overwritten inside another cache warmer provided by the ThemeBundle or maybe there is some way to adjust this in time.

Might be related to #6

lsmith77 commented 13 years ago

i am beginning to suspect that the cache approach implemented in Symfony\Bundle\FrameworkBundle\Templating\Loader\templateLocator is simply incompatible with the ThemeBundle, so I guess the cache lookup there would also need to be modified to take into account not only the logical name but also the theme and of course the templates.php cache file would need to be adjusted accordingly.

lsmith77 commented 13 years ago

@fabpot: so for this case my solution is to essentially undo what the templating cache warmer did.

lsmith77 commented 13 years ago

so i dont think this is related to #6 after all .. but PR #9 should fix the issue cleanly.