search

liip / TheA11yMachine

The A11y Machine is an automated accessibility testing tool which crawls and tests pages of any web application to produce detailed reports.
https://www.liip.ch/
621 stars 66 forks source link

vnu instance does not run W3C HTML ruleset #98

Closed stevefaulkner closed 7 years ago

stevefaulkner commented 7 years ago

By default the vnu.jar is not built to run the W3C HTML ruleset,which i suggest it should as the W3C HTML rules include additional/different HTML conformance rules that effect accessibility of content. Suggest that the vnu.jar shipped with a11ymachine be built with these rules enabled - there is a python script to do this: https://github.com/validator/validator/issues/444#issuecomment-274799727

Hywan commented 7 years ago

Hello 🙂,

Excellent suggestion indeed. Will try to do that soon. Thanks!

stevefaulkner commented 7 years ago

@Hywan Testing this locally it doesn't run the w3c version, also when running web UI it displays the whatwg links also this line needs updating --html5link=http://www.w3.org/html/wg/drafts/html/master/single-page.html \ to --html5link=http://w3c.github.io/html/single-page.html \ \cc @sideshowbarker

Hywan commented 7 years ago

@stevefaulkner Makefile is here. Is it incorrect (except the --html5link option)?

sideshowbarker commented 7 years ago

The invocation in that makefile looks to me like it should produce a W3C-enabled vnu.jar as expected

sideshowbarker commented 7 years ago

OK sorry for not catching this before but I remember now that to get the W3C stuff, vnu.jar must also be run with some Java system properties specified.

To run the jar for command-line checking:

java -Dnu.validator.servlet.follow-w3c-spec=1 \
  -Dnu.validator.spec.html5-link=http://www.w3.org/html/wg/drafts/html/master/single-page.html \
  -jar ./build/dist/vnu.jar FILES…

…and to run it for Web-based checking:

java -Dnu.validator.servlet.follow-w3c-spec=1 \
  -Dnu.validator.spec.html5-link=http://www.w3.org/html/wg/drafts/html/master/single-page.html \
  -cp ./build/dist/vnu.jar nu.validator.servlet.Main 8888