liip / django-template

Project template for Django projects
MIT License
17 stars 14 forks source link

Use pipenv #49

Open sephii opened 6 years ago

sephii commented 6 years ago

And remove code that loads variables from envdir and use python-decouple to handle environment-specific settings: https://pypi.org/project/python-decouple/. This should also fix https://github.com/liip/django-template/pull/23.

simonbru commented 6 years ago

Should we also use python-decouple to load variables in the fabfile ?

By the way, I tried activating the virtualenv from .bashrc by sourcing the activate script and it seems to work: https://github.com/simonbru/drifter/commit/67e6e4bdea431c4c6cd58a83d5af18e91f024b9a. Environments variables are not loaded when activating the virtualenv this way, but this may not be an issue if we load them ourselves with python-decouple.

Do you remember which issues you encountered when trying a similar approach ?

EDIT: Using python-decouple in fabfile is probably overkill