liip / serializer

A PHP serializer that generates PHP code for maximum performance
MIT License
127 stars 10 forks source link

Improvement: Assign multidimensional arrays for primitives directly #42

Closed drieschel closed 11 months ago

drieschel commented 11 months ago

This MR is intended to improve the performance when serializing multidimensional arrays for primitives.

@dbu Does it make sense also to replace the depracted PropertyTypeArray hints by PropertyTypeIterable in the SerializerGenerator* class? Or would BC be broken by this change?

*Non full qualified names

dbu commented 11 months ago

very cool, thanks!

i would not replace the deprecated types yet, we should only do that in the next major version to avoid problems if somebody wrote their own parser or their own parser plugins.

dbu commented 11 months ago

great work, thanks!

dbu commented 11 months ago

https://github.com/liip/serializer/releases/tag/2.5.1