search

lijunle / Vsxmd

VS XML documentation -> Markdown syntax.
MIT License
215 stars 51 forks source link

Add MSBuild namespace to Vsxmd.targets #69

Closed benjspriggs closed 5 years ago

benjspriggs commented 5 years ago

summary

This PR addresses issues raised by #68.

benjspriggs commented 5 years ago

Pinging @lijunle for review.

lijunle commented 5 years ago

@benjspriggs If we want to ensure VS2015 support, it is worth to declare VS2015 in AppVeyor CI.

lijunle commented 5 years ago

@benjspriggs I tried to declare VS2015 as official support but found the CSPROJ file format is completely changed from MSBuild14 to dotnet. I feel like it is not worth to officially support VS2015. But if you think this one line change could solve your problem, I could like to merge it. OK?

benjspriggs commented 5 years ago

It seems the Appveyor error is coming from an incompatibility between the VS2017+ versions of .csproj files and the VS2015 versions of .csproj files.

Ultimately, I don't think it'd be worth it to convert the Vsxmd.csproj file to a VS2015 compatible format, but I do think it'd be worth it for VS2015 to at least be able to use this via Nuget. If it's possible this fixes the problem, I would like to merge it, even if building via VS2015 isn't officially supported.