search

lijunle / Vsxmd

VS XML documentation -> Markdown syntax.
MIT License
215 stars 51 forks source link

Build failure under Alpine Linux #76

Closed FlushablPet closed 4 years ago

FlushablPet commented 4 years ago

Hi, first off, great tool, I love it.

It looks like it doesn't have Alpine compatible binaries though, as it caused our CI pipeline's build stage to fail when used with the Dotnet Core Alpine image mcr.microsoft.com/dotnet/core/sdk:3.1-alpine. Switching to an Ubuntu flavor worked, however adding Alpine support to the package for those working in lightweight CI environments would be a bonus as Alpine continues to increase in popularity.

/root/.nuget/packages/vsxmd/1.4.4/build/Vsxmd.targets(16,5): error MSB3073: The command ""/root/.nuget/packages/vsxmd/1.4.4/build//../tools/linux-x64/Vsxmd" "Wyatt.Data.xml" "" """ exited with code 127.
lijunle commented 4 years ago

Hi, @FlushablPet

For sure that, I could like to support alpine. Let me try if I could repro it. If it is a x64 distribution, it should work.

lijunle commented 4 years ago

I can repro it and identify the cause. Apline does not belong to linux-x64 group, but linux-musl-x64. See here.

I will include that into build and fix this issue.

lijunle commented 4 years ago

@FlushablPet

I published the version 1.4.5-beta.1 on addressing this. Please help on testing it and let me know. Thanks a lot on reporting this!

FlushablPet commented 4 years ago

Just tested it in the CI and Docker builds, both worked like a charm. Thanks so much for adding it so quickly!

lijunle commented 4 years ago

Thanks for helping testing! I merged my changes to master and published v1.4.5 for it. Again, thank you for reporting this issue!